Remove axios dependency and replace with native fetch in web-ui#7386
Closed
aajisaka wants to merge 4 commits intoapache:masterfrom
Closed
Remove axios dependency and replace with native fetch in web-ui#7386aajisaka wants to merge 4 commits intoapache:masterfrom
aajisaka wants to merge 4 commits intoapache:masterfrom
Conversation
github-actions
Bot
added
kind:infra
Member
Author
|
Thank you @pan3793. Addressed the review comments. |
yaooqinn
approved these changes
Apr 20, 2026
Replace axios with the native Fetch API in request.ts, removing the axios dependency from package.json. Enforce Node.js >=18 via the engines field and update README accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- api/v1/ping returns text/plain 'pong'; returning undefined for non-JSON
responses caused useAuthStore.setUser to always throw 'Authentication failed'.
Now return the text body when non-JSON.
- On non-2xx responses, read the body and attach it as err.response = { status, data }
so existing callers (e.g. Editor.vue) can surface the server-provided message
via err.response.data.message, matching the previous axios shape.
Member
|
verified locally, thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Replace axios with the native Fetch API in request.ts, removing the axios dependency from package.json. Reducing the dependent libraries to reduce the possibility of supply chain attack and to reduce future maintenance cost. Enforce Node.js >=18 via the engines field and update README accordingly.
How was this patch tested?
Covered by the existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6)